Update utils.py to handle SecretStr field type as str with password and load_from_db attributes #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sword and load_from_db attributes
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
dosubot
bot
added
size:S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
utils.pyfile to handle theSecretStrfield type as a string with thepasswordandload_from_dbattributes. This ensures that theSecretStrfield type is properly handled and allows for more secure and efficient handling of sensitive information.I'm proposing we use
SecretStras a replacement for passingpasswordandload_from_dbin thebuild_config. We'd also instantiate a SecretStr as soon as we got the Global Variable value from the database and pass it to the CustomComponent.This means that all credential fields would be passed in as SecretStr and not as str anymore.