Fix and Enhance Modal, Button, and Layout Functionality #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to 5 to optimize test execution ♻️ (addNewVariableButton.tsx): remove unused Button import and add data-testid to Save Variable button for better testing ♻️ (index.tsx): add preventDefault to button click handlers to prevent form submission ♻️ (sideBarFolderButtons): add data-testid attributes to buttons and inputs for better testing and readability ♻️ (api.tsx): refactor duplicate request check logic into helper function ✨ (api.tsx): add helper function to check and store duplicate requests ♻️ (genericNode): refactor code for better readability and maintainability 💡 (genericNode): add data-testid attribute for testing purposes 🐛 (use-fetch-data-on-mount): fix error handling to prevent undefined errors 🐛 (use-handle-new-value.tsx, use-handle-refresh-buttons.tsx): fix potential undefined errors in error handling ✨ (baseModal/index.tsx, flowSettingsModal/index.tsx): add data-testid attributes for better testability ♻️ (editNodeModal/index.tsx): refactor code for better readability and consistency ♻️ (nodeToolbarComponent): remove trailing commas to improve code style ♻️ (GeneralPage): reorder imports and remove trailing commas for consistency ✅ (chatInputOutput.spec.ts): update path to ChatTest.json for better file organization ✅ (chatInputOutputUser.spec.ts): add additional interactions to chat test ✅ (dragAndDrop.spec.ts): update file path for collection.json ✅ (dropdownComponent.spec.ts): fix formatting and improve locator usage ✅ (filterEdge.spec.ts): fix locator strings and remove redundant code ✅ (floatComponent.spec.ts): remove redundant cache checks and fix locator strings ✅ (flowSettings.spec.ts): update test to use data-testid for save button ✅ (folders.spec.ts): refactor folder creation and editing to use data-testid ✅ (globalVariables.spec.ts): remove redundant save button click in test ✅ (tests): update test locators to use more specific selectors - Change locators for "Save Changes" button to use `getByText` with exact match - Update locators for `showchroma_server_http_port` in `inputComponent.spec.ts` - Add additional test steps in `intComponent.spec.ts` for better coverage ✅ (keyPairListComponent.spec.ts, langflowShortcuts.spec.ts, logs.spec.ts): update locators for better test stability and readability ✅ (tests): update end-to-end tests for improved stability and accuracy ✅ (textInputOutput.spec.ts): update locators and placeholders for accuracy ✅ (toggleComponent.spec.ts): replace locators with getByText for clarity
|
All tests fixed and passed. |
…ularity ✨ (GeneralPage): add custom hooks for patching gradient, password, and saving API key 💡 (GeneralPage): add useScrollToElement hook to handle smooth scrolling to elements ✨ (hooks): add useSaveKey and useScrollToElement custom hooks ✅ (tests): update end-to-end tests for improved stability and accuracy
♻️ (frontend): refactor BaseModal to use switchCaseModalSize helper ✨ (frontend): add GeneralPageHeaderComponent for settings page header ✨ (frontend): add PasswordFormComponent for password management in settings page ✨ (SettingsPage): add ProfileGradientFormComponent to allow users to choose profile gradient ✨ (SettingsPage): add StoreApiKeyFormComponent to enable users to store API keys ♻️ (GeneralPage): refactor GeneralPage to use modular components for forms
Cristhianzl
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several fixes and enhancements related to modals, buttons, and layout elements within the application. The changes improve the user experience by addressing bugs, enhancing functionality, and refining UI components.
Summary of Changes
Modals:
storeApiKeyModal.deleteConfirmationModal.Node and Component Enhancements:
UI and Layout Adjustments:
General Fixes and Improvements:
asChild.Additional Changes
origin/devintofix/minor_bugson multiple occasions to keep the branch up-to-date with the latest developments.Notes