Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add types to functions, components and hooks that are missing it #2411

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Feat: Add types to functions, components and hooks that are missing it #2411

merged 2 commits into from
Jun 28, 2024

Conversation

anovazzi1
Copy link
Contributor

@anovazzi1 anovazzi1 commented Jun 27, 2024 •
edited by ogabrielluiz
Loading

cherry pick from #2340 which adds more types to frontend code.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 27, 2024
@dosubot dosubot bot added the javascript Pull requests that update Javascript code label Jun 27, 2024
github-actions[bot]
github-actions bot requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a more meaningful PR title with at least 15 characters.

italojohnny
italojohnny approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@italojohnny italojohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 27, 2024
@ogabrielluiz ogabrielluiz changed the title UpdateTypes Feat: Add types to functions, components and hooks that are missing it Jun 27, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jun 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 27, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jun 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2024
@ogabrielluiz ogabrielluiz added this pull request to the merge queue Jun 28, 2024
Merged via the queue into dev with commit 4c9f3c1 Jun 28, 2024
25 of 30 checks passed
@ogabrielluiz ogabrielluiz deleted the updateTypes branch June 28, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italojohnny italojohnny italojohnny approved these changes

@github-actions github-actions[bot] github-actions approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@anovazzi1 @italojohnny @ogabrielluiz @igorrCarvalho