Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update condition to run end_all_traces #2707

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

ogabrielluiz
Copy link
Contributor

This pull request adds a new method to the codebase that checks if all predecessors of a vertex are fulfilled. This method is used to determine if a vertex can be marked as inactive. Additionally, the code has been updated to remove a vertex from the predecessors when marking it as inactive. This improves the efficiency of the code and ensures that all traces are properly ended when necessary.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 15, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 15 Jul 24 16:12 UTC

@ogabrielluiz ogabrielluiz merged commit 537e358 into main Jul 15, 2024
22 of 28 checks passed
@ogabrielluiz ogabrielluiz deleted the stop_condition branch July 15, 2024 16:13
@github-actions github-actions bot added the bug Something isn't working label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant