Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assign frozen flag from group to node correctly #2867

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

ogabrielluiz
Copy link
Contributor

This pull request fixes the assignment of node["frozen"] in the add_frozen function by updating it to node["data"]["node"]["frozen"]. Additionally, it removes unnecessary code related to vertex.parent_node_id in the Graph class. These changes improve the accuracy and efficiency of the code.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jul 22, 2024
Copy link
Contributor

Pull Request Validation Report

This comment is automatically generated by Conventional PR

Whitelist Report

Whitelist Active Result
Pull request is a draft and should be ignored
Pull request is made by a whitelisted user and should be ignored
Pull request is submitted by a bot and should be ignored
Pull request is submitted by administrators and should be ignored

Result

Pull request does not satisfy any enabled whitelist criteria. Pull request will be validated.

Validation Report

Validation Active Result
All commits in this pull request has valid messages
Pull request does not introduce too many changes
Pull request has a valid title
Pull request has mentioned issues
Pull request has valid branch name
Pull request should have a non-empty body

Result

Pull request satisfies all enabled pull request rules.

Last Modified at 22 Jul 24 13:03 UTC

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Jul 22, 2024
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 22, 2024
@Cristhianzl Cristhianzl enabled auto-merge (squash) July 22, 2024 13:04
@Cristhianzl Cristhianzl merged commit 724f540 into main Jul 22, 2024
11 of 12 checks passed
@Cristhianzl Cristhianzl deleted the fix/freeze_group branch July 22, 2024 13:04
anovazzi1 pushed a commit that referenced this pull request Jul 22, 2024
* fix: remove unnecessary code related to vertex parent_node_id in Graph class

* fix: update node["frozen"] assignment to node["data"]["node"]["frozen"] in add_frozen function
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request Jul 30, 2024
* fix: remove unnecessary code related to vertex parent_node_id in Graph class

* fix: update node["frozen"] assignment to node["data"]["node"]["frozen"] in add_frozen function

(cherry picked from commit 724f540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants