We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
meta.update()
meta = None
This was incorrectly filed against the langfuse repo first (see langfuse/langfuse#1775)
I believe this Commit da264a9 from last week has introduced a bug at https://github.com/langfuse/langfuse-python/blame/main/langfuse/callback/langchain.py#L722 by allowing returning None (edit: it seems the version before the commit has also allowed returning None, so it is interesting why I only see this now), which then fails at https://github.com/langfuse/langfuse-python/blame/main/langfuse/callback/langchain.py#L445, as None doesn't have an update() method
None
update()
Run a callback with no metadata or tags and you will hit an error:
File "/..../lib/python3.10/site-packages/langfuse/callback/langchain.py", line 443, in on_tool_start meta.update( └ None
No response
The text was updated successfully, but these errors were encountered:
meta
Bugfix: to fix issue #599 where meta can be None (#598)
c63a823
Bugfix: to fix issue #1775 where `meta` can be `None` `meta` can be `None`, see https://github.com/langfuse/langfuse-python/blob/main/langfuse/callback/langchain.py#L722, but `meta.update()` at https://github.com/langfuse/langfuse-python/blob/main/langfuse/callback/langchain.py#L445 would fail on `None`
fix: issue #599 where meta can be None (#600)
5f1f3a6
Co-authored-by: Zoltan Fedor <zoltan.0.fedor@gmail.com>
thanks for your contribution on this 🙏 released in https://github.com/langfuse/langfuse-python/releases/tag/v2.27.0
Sorry, something went wrong.
No branches or pull requests
This was incorrectly filed against the langfuse repo first (see langfuse/langfuse#1775)
Describe the bug
I believe this Commit da264a9 from last week has introduced a bug at https://github.com/langfuse/langfuse-python/blame/main/langfuse/callback/langchain.py#L722 by allowing returning
None
(edit: it seems the version before the commit has also allowed returningNone
, so it is interesting why I only see this now), which then fails at https://github.com/langfuse/langfuse-python/blame/main/langfuse/callback/langchain.py#L445, asNone
doesn't have anupdate()
methodTo reproduce
Run a callback with no metadata or tags and you will hit an error:
Additional information
No response
The text was updated successfully, but these errors were encountered: