Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): redirect to targetPath after login #1913

Merged
merged 11 commits into from
May 2, 2024
Merged

feat(auth): redirect to targetPath after login #1913

merged 11 commits into from
May 2, 2024

Conversation

InosRahul
Copy link
Contributor

What does this PR do?

Fixes #1093

Loom Video: https://www.loom.com/share/a5da2b975d3c42f7a2c7e63cdcc102b6?sid=a5a83a36-3fa3-4f47-a242-b68335ca96bb

Type of change

  • New feature (non-breaking change which adds functionality)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@vercel Vercel
Copy link

vercel bot commented Apr 30, 2024

@InosRahul is attempting to deploy a commit to the langfuse Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

marcklingen
marcklingen reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@marcklingen marcklingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution, this looks good mostly, can you remove this line?

web/src/components/layouts/layout.tsx Outdated Show resolved Hide resolved
marcklingen
marcklingen reviewed May 1, 2024
View reviewed changes
Copy link
Member

@marcklingen marcklingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made little changes (cosmetic), one last questions, otherwise seems good to go. thank you!

web/src/components/layouts/layout.tsx Show resolved Hide resolved
@vercel Vercel
Copy link

vercel bot commented May 1, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-cloud ✅ Ready (Inspect) Visit Preview May 1, 2024 0:56am

marcklingen
marcklingen requested changes May 1, 2024
View reviewed changes
Copy link
Member

@marcklingen marcklingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made additional changes, PR ready to merge but tests keep failing. Can you fix the end to end test?

web/src/__e2e__/auth.spec.ts Outdated

await expect(page).toHaveURL(/.*traces/);

await page
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test seems to fail, can you fix it?

@marcklingen marcklingen changed the title feat(auth): Redirect User to Target URL after Login feat(auth): redirect to targetPath after login May 1, 2024
@marcklingen
Copy link
Member

maybe you can just try to navigate to /settings of the project without really needing to press any buttons beyond the login screen, assuming that this is the issue here

@InosRahul InosRahul force-pushed the feat/post_login_redirect_url branch from 79f3466 to e983e02 Compare May 2, 2024 05:02
@InosRahul
Copy link
Contributor Author

maybe you can just try to navigate to /settings of the project without really needing to press any buttons beyond the login screen, assuming that this is the issue here

Fixed now, also cleaned up the commits.

@marcklingen
Copy link
Member

Looks great, the worker CI test fails on forks, we're about to fix this to make it easier to contribute to langfuse

@marcklingen
Copy link
Member

Thank you for your contribution!

@marcklingen marcklingen merged commit 52cfba8 into langfuse:main May 2, 2024
8 of 12 checks passed
@marcklingen marcklingen mentioned this pull request May 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcklingen marcklingen marcklingen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(auth): post-login redirect to initial url
3 participants
@InosRahul @CLAassistant @marcklingen