Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(score_configs): add table via migration #2126

Merged
merged 34 commits into from
May 23, 2024
Merged

feat(score_configs): add table via migration #2126

merged 34 commits into from
May 23, 2024

Conversation

marliessophie
Copy link
Member

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langfuse-cloud ✅ Ready (Inspect) Visit Preview May 23, 2024 2:54pm
langfuse-cloud-us 🔄 Building (Inspect) Visit Preview May 23, 2024 2:54pm

@marliessophie marliessophie changed the base branch from main to marlies/lfe-1236 May 22, 2024 12:49
Base automatically changed from marlies/lfe-1236 to main May 22, 2024 13:47
@marliessophie marliessophie marked this pull request as ready for review May 23, 2024 09:52
marcklingen
marcklingen reviewed May 23, 2024
View reviewed changes
Copy link
Member

@marcklingen marcklingen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks good to me! added quick note re backfill, i think defaulting here is probably fine and makes this faster to deploy. we can later switch to non-null without default and make sure to always set the type on the application layer

packages/shared/prisma/migrations/20240523115814_scores_backfill_data_type/migration.sql Outdated Show resolved Hide resolved
@marliessophie marliessophie merged commit a6d8ce8 into main May 23, 2024
14 checks passed
@marliessophie marliessophie deleted the marlies/lfe-1238 branch May 23, 2024 17:26
@marliessophie marliessophie changed the title feat(annotation_config): add table via migration feat(score_configs): add table via migration May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcklingen marcklingen marcklingen left review comments

@maxdeichmann maxdeichmann maxdeichmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marliessophie @marcklingen @maxdeichmann