Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing 'version' from docker-compose.yml file #2389

Merged

Conversation

mukesh1811
Copy link
Contributor

What does this PR do?

removed 'version' tag from docker-compose.yml file as 'version' was made obsolete
reference

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Copy link

vercel bot commented Jun 21, 2024

@mukesh1811 is attempting to deploy a commit to the langfuse Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

@mukesh1811 mukesh1811 changed the title removing 'version' removing 'version' from docker-compose.yml file Jun 21, 2024
@mukesh1811 mukesh1811 marked this pull request as ready for review June 21, 2024 05:42
@marcklingen
Copy link
Member

thanks! as version 2 completely ignores the version and has been released a long time ago, this is safe to be removed. merging now.

from faq:

Version two of the Docker Compose command-line binary was announced in 2020, is written in Go, and is invoked with docker compose. Compose V2 ignores the version top-level element in the compose.yml file.

@marcklingen marcklingen changed the title removing 'version' from docker-compose.yml file chore: removing 'version' from docker-compose.yml file Jun 21, 2024
@marcklingen marcklingen merged commit aebcac4 into langfuse:main Jun 21, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants