Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change Yi model SDK to OpenAI #2910

Merged
merged 2 commits into from Mar 20, 2024

Conversation

soulteary
Copy link
Contributor

Description

Models like Yi that use OpenAI's SDK will have better performance, be able to use more SDK functions, and most importantly, have lower maintenance costs.

Type of Change

Please delete options that are not relevant.

  • Improvement,including but not limited to code refactoring, performance optimization, and UI/UX improvement

How Has This Been Tested?

VL model

image
image

NLP model

image
image

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 20, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the 🌞 lgtm This PR has been approved by a maintainer label Mar 20, 2024
@crazywoola crazywoola merged commit 5a1c29f into langgenius:main Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌞 lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants