Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update wenxin llm #2929

Merged
merged 7 commits into from Mar 27, 2024
Merged

update wenxin llm #2929

merged 7 commits into from Mar 27, 2024

Conversation

Weaxs
Copy link
Contributor

@Weaxs Weaxs commented Mar 21, 2024

Description

update wenxin llm

  • ERNIE-4.0-8K (old name: ERNIE-Bot-4.0)
  • ERNIE-3.5
    • ERNIE-3.5-8K (old name: ERNIE-Bot-8K)
    • ERNIE-3.5-8K-0205
    • ERNIE-3.5-8K-1222
    • ERNIE-3.5-4K-0205 (old name: ERNIE-Bot)
  • ERNIE-Speed
    • ERNIE-Speed-8K
    • ERNIE-Speed-128K
  • ERNIE-Lite
    • ERNIE-Lite-8K-0922 (old name: ERNIE-Bot-Turbo)
    • ERNIE-Lite-8K-0308

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement,including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 21, 2024
@bowenliang123
Copy link
Contributor

One major question first, is that ernie model a Baidu's product 文心一言?
Why it's described as wechat in the title and description ?

@Weaxs
Copy link
Contributor Author

Weaxs commented Mar 22, 2024

One major question first, is that ernie model a Baidu's product 文心一言? Why it's described as wechat in the title and description ?

yeah, 文心大模型3.5 is ernie-3.5-8k and 文心大模型4.0 is ernie-4.0-8k in fact

@Yeuoly
Copy link
Collaborator

Yeuoly commented Mar 22, 2024

Thanks a lot!
But to forward compatibility, A deprecated field should be set in the yaml file instead of removing it, you can refer to core.model_runtime.model_providers.openai.llm.text-davinci-003.yaml, deprecated: true will be found there.

Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the lint errors in CI build.

max_tokens -> max_output_tokens
presence_penalty -> penalty_score

default use ernie-3.5-8k in test case
@dosubot dosubot bot added the 🌞 lgtm This PR has been approved by a maintainer label Mar 25, 2024
crazywoola
crazywoola previously approved these changes Mar 25, 2024
@Weaxs Weaxs requested a review from Yeuoly March 25, 2024 15:31
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lots, bu after read the document of ernie not, there is something small details need to be revised

Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yeuoly Yeuoly merged commit 5becb4c into langgenius:main Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌞 lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants