Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve header.uid' length must be less or equal than 32 on Spark V1.5 #2983

Merged
merged 4 commits into from Mar 27, 2024

Conversation

Kennytian
Copy link
Contributor

@Kennytian Kennytian commented Mar 26, 2024

Description

fix: parameter user exceeded max length(32 words) when invoking Spark V1.5 llm

Fixes #2982

I referenced this modify:
https://github.com/langgenius/dify/blob/main/api/core/model_runtime/model_providers/moonshot/llm/llm.py#L16

Type of Change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual test

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 26, 2024
@dosubot dosubot bot added the 🌞 lgtm This PR has been approved by a maintainer label Mar 26, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the official site of Spark. It's not deprecated.

@crazywoola crazywoola removed the 🌞 lgtm This PR has been approved by a maintainer label Mar 26, 2024
@Kennytian Kennytian changed the title fix: update Spark V1.5 as deprecated fix: resolve header.uid' length must be less or equal than 32 on Spark V1.5 Mar 26, 2024
@Kennytian
Copy link
Contributor Author

Kennytian commented Mar 26, 2024

I checked the official site of Spark. It's not deprecated.

Thanks for your response, I have revised my submission, referencing the same issue with the moonshot LLM.

@crazywoola Please review it again, thank you!

crazywoola
crazywoola previously approved these changes Mar 27, 2024
@dosubot dosubot bot added the 🌞 lgtm This PR has been approved by a maintainer label Mar 27, 2024
@crazywoola crazywoola merged commit 1369429 into langgenius:main Mar 27, 2024
7 checks passed
@Kennytian Kennytian deleted the patch-1 branch March 27, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌞 lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spark V1.5 is not work
2 participants