Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix claude request errors in bedrock #3015

Merged
merged 6 commits into from Mar 29, 2024
Merged

Fix claude request errors in bedrock #3015

merged 6 commits into from Mar 29, 2024

Conversation

guchenhe
Copy link
Collaborator

@guchenhe guchenhe commented Mar 28, 2024

Fixes #2942

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran integration tests + manually tested in local dev environment

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 28, 2024
crazywoola and others added 3 commits March 28, 2024 17:07
create launch.json config

optionally specify available bedrock model used in validation
@dosubot dosubot bot added the 🌞 lgtm This PR has been approved by a maintainer label Mar 29, 2024
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takatost takatost merged commit 9d96205 into main Mar 29, 2024
10 checks passed
@takatost takatost deleted the fix/bedrock-claude branch March 29, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌞 lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS Bedrock Provider: required key [max_tokens_to_sample] not found
3 participants