Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ModelTypeEnum type #3051

Merged
merged 1 commit into from Apr 4, 2024
Merged

Improve ModelTypeEnum type #3051

merged 1 commit into from Apr 4, 2024

Conversation

lng2020
Copy link
Contributor

@lng2020 lng2020 commented Mar 31, 2024

Description

Get rid of magic number

Type of Change

Please delete options that are not relevant.

  • Improvement， including but not limited to code refactoring, performance optimization, and UI/UX improvement

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ☕️ javascript Pull requests that update Javascript code 💪 enhancement New feature or request labels Mar 31, 2024
@crazywoola crazywoola requested review from zxhlyh, GarfieldDai and iamjoel and removed request for GarfieldDai March 31, 2024 04:42
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 3, 2024
@crazywoola crazywoola merged commit 718ac3f into langgenius:main Apr 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxhlyh zxhlyh zxhlyh approved these changes

@iamjoel iamjoel Awaiting requested review from iamjoel

Assignees
No one assigned
Labels
💪 enhancement New feature or request ☕️ javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lng2020 @zxhlyh @crazywoola