Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chat app sometimes may crash #3151

Merged
merged 1 commit into from Apr 8, 2024
Merged

fix: chat app sometimes may crash #3151

merged 1 commit into from Apr 8, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Apr 8, 2024

Description

Sometimes visionConfig undefined makes chat app crash.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@iamjoel iamjoel requested a review from takatost April 8, 2024 06:33
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ javascript Pull requests that update Javascript code 🐞 bug Something isn't working labels Apr 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2024
@iamjoel iamjoel merged commit 9748282 into main Apr 8, 2024
10 checks passed
@iamjoel iamjoel deleted the fix/chat-app-may-crash branch April 8, 2024 06:37
iamjoel added a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working ☕️ javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants