Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata in generate npe issue #3166

Merged
merged 1 commit into from Apr 8, 2024
Merged

fix: metadata in generate npe issue #3166

merged 1 commit into from Apr 8, 2024

Conversation

takatost
Copy link
Collaborator

@takatost takatost commented Apr 8, 2024

Description

fix: metadata in generate npe issue

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual Test

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐍 python Pull requests that update Python code 🐞 bug Something isn't working labels Apr 8, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 8, 2024
@takatost takatost merged commit 9720d6b into main Apr 8, 2024
9 checks passed
@takatost takatost deleted the fix/metadata-npe branch April 8, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer 🐍 python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants