Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for PKCS1OAEP_Cipher with gmpy2 #3760

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Apr 24, 2024

Description

  • add test for PKCS1OAEP_Cipher, including the transparent usage onto gmpy2 lib

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 24, 2024
@bowenliang123 bowenliang123 marked this pull request as draft April 24, 2024 07:11
@bowenliang123 bowenliang123 changed the title test: add test for PKCS1OAEP_Cipher test: add test for PKCS1OAEP_Cipher with gmpy2 Apr 24, 2024
@bowenliang123 bowenliang123 marked this pull request as ready for review April 24, 2024 07:56
@dosubot dosubot bot added the 💪 enhancement New feature or request label Apr 24, 2024
@bowenliang123
Copy link
Contributor Author

cc @takatost

Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 24, 2024
@takatost takatost merged commit a34e8cb into langgenius:main Apr 24, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the test-gmpy2 branch April 24, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants