Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract enum type for tenant account role #3788

Merged
merged 8 commits into from
Apr 25, 2024

Conversation

bowenliang123
Copy link
Contributor

Description

  • extract enum for Account role, to extract method for checking privileged role and prevent magic values

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐍 python Pull requests that update Python code 💪 enhancement New feature or request labels Apr 24, 2024
@bowenliang123 bowenliang123 changed the title extract Account role enum extract Account Role enum Apr 24, 2024
GarfieldDai
GarfieldDai previously approved these changes Apr 25, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 25, 2024
@bowenliang123
Copy link
Contributor Author

Which name for this enum would you prefer? The AccountRole or TenantAccountRole or TenantRole? @GarfieldDai

@GarfieldDai
Copy link
Contributor

@bowenliang123 TenantAccountRole would be perfect.

@bowenliang123 bowenliang123 changed the title extract Account Role enum extract enum type for tenant account role Apr 25, 2024
@bowenliang123
Copy link
Contributor Author

Thanks, adopted. Please check. cc @GarfieldDai

@crazywoola crazywoola merged commit c54fcfb into langgenius:main Apr 25, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the account-role branch April 25, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer 🐍 python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants