Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tool: Firecrawl #3819

Merged
merged 18 commits into from
Apr 29, 2024
Merged

Add new tool: Firecrawl #3819

merged 18 commits into from
Apr 29, 2024

Conversation

richards199999
Copy link
Contributor

@richards199999 richards199999 commented Apr 25, 2024 •
edited
Loading

Description

Since the combination of Bing Search and JinaReader is always slow, so I add this new tool that do search and scrap at the same time. Official Intro

Type of Change

  • New feature (non-breaking change which adds functionality)

TODO Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🔨 feat:tools Tools for agent, function call related stuff. labels Apr 25, 2024
takatost
takatost requested changes Apr 25, 2024
View reviewed changes
api/requirements.txt Show resolved Hide resolved
@takatost takatost requested a review from Yeuoly April 25, 2024 14:30
@takatost
Copy link
Collaborator

@Yeuoly Can you help review this PR?

Yeuoly
Yeuoly approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2024
@Yeuoly Yeuoly merged commit f26ad16 into langgenius:main Apr 29, 2024
7 checks passed
@richards199999
Copy link
Contributor Author

Thank you!!!!!!!😭😭😭😭 @Yeuoly

@takatost takatost mentioned this pull request May 2, 2024
Merged
@BradKML
Copy link

BradKML commented May 29, 2024

@richards199999 Does this include the localized implementation rather than the external API implementation? Apparently Ollama can be used as a drop-in replacement mendableai/firecrawl#195

dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
@richards199999 @crazywoola
@Yeuoly @dengpeng
Add new tool: Firecrawl (langgenius#3819)
da4c8bf 
Co-authored-by: crazywoola <427733928@qq.com>
Co-authored-by: Yeuoly <admin@srmxy.cn>
@WilliamEspegren WilliamEspegren mentioned this pull request Jun 28, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takatost takatost takatost requested changes

@crazywoola crazywoola crazywoola requested changes

@Yeuoly Yeuoly Yeuoly approved these changes

Assignees
No one assigned
Labels
🔨 feat:tools Tools for agent, function call related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@richards199999 @takatost @BradKML @Yeuoly @crazywoola