Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add google storage support #3887

Merged
merged 3 commits into from
Apr 27, 2024

Conversation

miendinh
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 💪 enhancement New feature or request labels Apr 26, 2024
@miendinh miendinh force-pushed the feat/support-google-storage branch from a30c80f to 6ce7d70 Compare April 26, 2024 08:54
@miendinh miendinh changed the title feat: Add azure blob storage support feat: Add google storage support Apr 26, 2024
api/.env.example Outdated Show resolved Hide resolved
@takatost
Copy link
Collaborator

The support for storage is increasing, we will consider splitting storage into factory methods in the future. 🥲

@miendinh
Copy link
Contributor Author

The support for storage is increasing, we will consider splitting storage into factory methods in the future. 🥲

Vector Database Support, I think it should also be refactored to use factory methods. @takatost

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 27, 2024
@JohnJyong JohnJyong requested a review from takatost April 27, 2024 08:42
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takatost takatost merged commit 9ad489d into langgenius:main Apr 27, 2024
7 checks passed
@takatost takatost mentioned this pull request May 2, 2024
evnydd0sf pushed a commit to evnydd0sf/dify that referenced this pull request May 10, 2024
Co-authored-by: miendinh <miendinh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants