Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled Notion integration setup in Docker Compose Deployment #3919

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kei-yamazaki
Copy link
Contributor

@kei-yamazaki kei-yamazaki commented Apr 27, 2024

Description

Among the two methods of self-hosting, the Local Source Code Start allows for the use of Notion Integration by creating a .env file. However, for the other method, Docker Compose Deployment, there was no way to set environment variables for Notion Integration, so it couldn't be used. Therefore, I made it possible to set the environment variables for Notion Integration in the docker-compose.yaml file.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

I performed operational tests using the Internal type of Notion Integration.

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 27, 2024
@JohnJyong JohnJyong self-requested a review April 27, 2024 08:34
@JohnJyong
Copy link
Contributor

It looks good in api service, but both api and worker services are needed, thanks @kei-yamazaki

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 27, 2024
@crazywoola crazywoola self-requested a review April 27, 2024 16:21
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing worker configuration.

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Apr 27, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 28, 2024
@kei-yamazaki
Copy link
Contributor Author

Thanks for the feedback.
I added the settings to worker.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2024
@crazywoola crazywoola merged commit 1d3f1d8 into langgenius:main Apr 30, 2024
7 checks passed
@kei-yamazaki kei-yamazaki deleted the notion-env branch April 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants