Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code full screen in web app cause error #3935

Merged
merged 1 commit into from
Apr 28, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Apr 28, 2024

Description

Code full screen in web app cause error.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@iamjoel iamjoel requested a review from JzoNgKVO April 28, 2024 03:54
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Apr 28, 2024
@iamjoel iamjoel requested a review from zxhlyh April 28, 2024 03:57
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 28, 2024
@iamjoel iamjoel merged commit ba88f8a into main Apr 28, 2024
10 checks passed
@iamjoel iamjoel deleted the fix/code-full-screen-in-webapp-error branch April 28, 2024 03:59
evnydd0sf pushed a commit to evnydd0sf/dify that referenced this pull request May 10, 2024
evnydd0sf pushed a commit to evnydd0sf/dify that referenced this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants