Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete duplicate check get_dataset #3966

Merged
merged 1 commit into from
Apr 29, 2024
Merged

delete duplicate check get_dataset #3966

merged 1 commit into from
Apr 29, 2024

Conversation

baxiang
Copy link
Contributor

@baxiang baxiang commented Apr 29, 2024

Duplicate query select dataset

Description

get_batch_documents exist **dataset = DatasetService.get_dataset(dataset_id) **

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

Duplicate query select dataset
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Apr 29, 2024
@baxiang baxiang changed the base branch from main to deploy/dev April 29, 2024 03:23
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 29, 2024
@baxiang baxiang changed the base branch from deploy/dev to main April 29, 2024 03:31
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 29, 2024
@takatost takatost requested a review from JohnJyong April 29, 2024 03:40
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 29, 2024
@JohnJyong JohnJyong changed the title 🐞 fix(dataset): delete get_dataset delete duplicate check get_dataset Apr 29, 2024
@JohnJyong JohnJyong merged commit 975b2fb into langgenius:main Apr 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants