Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support question classifier node output #4000

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

sinomoe
Copy link
Contributor

@sinomoe sinomoe commented Apr 30, 2024

Description

Supports fetching output from question-classifier node so that class_name can be fetched at a subsequent node.

Close #3963

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

tested in self-host environment

image image

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. 💪 enhancement New feature or request labels Apr 30, 2024
@sinomoe sinomoe marked this pull request as draft April 30, 2024 04:41
@sinomoe sinomoe marked this pull request as ready for review April 30, 2024 04:47
Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 30, 2024
@takatost takatost merged commit da5a8b9 into langgenius:main Apr 30, 2024
7 checks passed
@takatost takatost mentioned this pull request May 2, 2024
evnydd0sf pushed a commit to evnydd0sf/dify that referenced this pull request May 10, 2024
@sinomoe sinomoe deleted the feat/classify-node-output branch May 14, 2024 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request 🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the output variable in the question classifier module
2 participants