Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃 refactor(dataset svc): delete check none #4101

Merged
merged 1 commit into from
May 6, 2024

Conversation

baxiang
Copy link
Contributor

@baxiang baxiang commented May 6, 2024

func first() Return the first result of this Query or None if the result doesn鈥檛 contain any row.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

func first() Return the first result of this Query or None if the result doesn鈥檛 contain any row.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 馃悕 python Pull requests that update Python code labels May 6, 2024
@JohnJyong JohnJyong self-requested a review May 6, 2024 03:45
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 6, 2024
@JohnJyong JohnJyong merged commit 13292ff into langgenius:main May 6, 2024
7 checks passed
rennokki pushed a commit to rennokki/dify that referenced this pull request May 9, 2024
Co-authored-by: baxiang <baxiang@lixiang.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer 馃悕 python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants