Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add volcengine maas model provider #4142

Merged
merged 2 commits into from
May 8, 2024

Conversation

sinomoe
Copy link
Contributor

@sinomoe sinomoe commented May 7, 2024

Description

add volcengine maas models provider

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • self-host environment test
image image image

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. ⚙️ feat:model-runtime labels May 7, 2024
@takatost
Copy link
Collaborator

takatost commented May 7, 2024

Can you please add some integrate or unit tests?

@takatost takatost self-requested a review May 7, 2024 06:52
@sinomoe
Copy link
Contributor Author

sinomoe commented May 7, 2024

Can you please add some integrate or unit tests?

sure

@sinomoe
Copy link
Contributor Author

sinomoe commented May 7, 2024

Can you please add some integrate or unit tests?

@takatost Integration test cases have been added

@takatost
Copy link
Collaborator

takatost commented May 7, 2024

Can you please add some integrate or unit tests?

@takatost Integration test cases have been added

Thanks! We will review and test ASAP.

Copy link
Collaborator

@takatost takatost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't applied for the maas permission of Volcengine yet, but I have reviewed the code and found no issues. Thank you very much!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 8, 2024
@takatost takatost merged commit 4aa2124 into langgenius:main May 8, 2024
7 checks passed
rennokki pushed a commit to rennokki/dify that referenced this pull request May 9, 2024
@takatost takatost mentioned this pull request May 9, 2024
@sinomoe sinomoe deleted the feat/volcmaas-provider branch May 14, 2024 01:34
@crazywoola
Copy link
Member

Hello please add my wechat crazyphage, I will invite you to our contributors' group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants