Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix delete log annotation #4201

Merged
merged 1 commit into from
May 9, 2024

Conversation

cainiaokan
Copy link
Contributor

this is a fix of issue #4200

  1. changes of web/app/components/app/log/list.tsx make sure remove annotation can get the right annotation id
  2. changes of web/app/components/app/chat/index.tsxmake sure this annotation is properly removed. if not this message would still be tagged as annotated and the remove annotation button is still there

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels May 9, 2024
@zxhlyh zxhlyh self-requested a review May 9, 2024 03:49
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 9, 2024
@zxhlyh zxhlyh merged commit ca5081e into langgenius:main May 9, 2024
7 checks passed
@cainiaokan cainiaokan deleted the hotfix/delete-log-annotation branch May 9, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants