Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: miss usage of os.path.join for URL assembly and add tests on yarl #4224

Merged
merged 1 commit into from
May 10, 2024

Conversation

bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented May 9, 2024

Description

  • fix the misusage of os.path.join for URL assembly , as os.path.join is OS dependent and it will cause "\" seperator on Windows platform in URL instead of the correct '/'
  • use and add test for yarl package for safer URL assembly

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐍 python Pull requests that update Python code 🐞 bug Something isn't working labels May 9, 2024
@bowenliang123
Copy link
Contributor Author

cc @Yeuoly

@takatost takatost requested a review from Yeuoly May 9, 2024 13:25
@bowenliang123 bowenliang123 changed the title fix: miss usage of os.path.join for URL assembly and add test with yarl package fix: miss usage of os.path.join for URL assembly and add tests on yarl May 9, 2024
Copy link
Collaborator

@Yeuoly Yeuoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 10, 2024
@Yeuoly Yeuoly merged commit 228de1f into langgenius:main May 10, 2024
7 checks passed
@bowenliang123 bowenliang123 deleted the fix-url branch May 10, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer 🐍 python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants