Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency package versions are not synchronized to requirements.txt #5084

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

takatost
Copy link
Collaborator

Description

fix: dependency package versions are not synchronized to requirements.txt
includes:

  • pandas = { version = "~2.2.2", extras = ["performance", "excel"] }
  • yfinance = "^0.2.40"
  • duckduckgo-search = "6.1.5"
  • azure-storage-blob = "12.13.0"
  • oss2 = "2.18.5"

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual test

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Jun 11, 2024
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We shall think about the alignment with pip and poetry in a more automated manchanism by tools or actions.

@takatost
Copy link
Collaborator Author

LGTM. We shall think about the alignment with pip and poetry in a more automated manchanism by tools or actions.

Maybe we can migrate early, including the Dockerfile and lint fix scripts, so we don't have to do any more automate checks.

@bowenliang123
Copy link
Contributor

Yes, agree with you. Keeping one building system is the solution.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jun 11, 2024
@takatost takatost merged commit e3544c6 into main Jun 11, 2024
10 checks passed
@takatost takatost deleted the fix/pyproject-dependencies branch June 11, 2024 14:21
dengpeng pushed a commit to dengpeng/dify that referenced this pull request Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants