Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default project to generate langium-config.json #219

Closed
spoenemann opened this issue Sep 15, 2021 · 0 comments · Fixed by #232
Closed

Change default project to generate langium-config.json #219

spoenemann opened this issue Sep 15, 2021 · 0 comments · Fixed by #232
Assignees
@jbicker
Labels
yeoman Yeoman generator related issue
Milestone
v0.2.0

Comments

@spoenemann
Copy link
Contributor

I'd propose to generate a langium-config.json file instead of embedding the configuration in the package.json (though we can keep supporting both variants in the CLI). This way we can offer JSON editing support to users (#218).
@spoenemann spoenemann added the yeoman Yeoman generator related issue label Sep 15, 2021
@spoenemann spoenemann added this to the v0.2.0 milestone Sep 15, 2021
@jbicker jbicker self-assigned this Sep 20, 2021
jbicker added a commit that referenced this issue Sep 21, 2021
@jbicker
Moved langium config...
7ebd600 
...from package.json to its own json file.
Fixes #219

Signed-off-by: jbicker <jan.bicker@typefox.io>
@jbicker jbicker mentioned this issue Sep 21, 2021
Merged
jbicker added a commit that referenced this issue Sep 22, 2021
@jbicker
Moved langium config...
9ba6a4a 
...from package.json to its own json file.
Fixes #219

Signed-off-by: jbicker <jan.bicker@typefox.io>
jbicker added a commit that referenced this issue Sep 22, 2021
@jbicker
Moved langium config...
491d28d 
...from package.json to its own json file.
Fixes #219

Signed-off-by: jbicker <jan.bicker@typefox.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbicker jbicker

Labels
yeoman Yeoman generator related issue
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging a pull request may close this issue.

Moved langium config from package.json to its own json file eclipse-langium/langium
2 participants
@spoenemann @jbicker