Bug fix for handling of variable length utf-8 chars #447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to guess the doc type, landroid reads in the first 1024 bytes and tries to decode it as utf-8.
Utf-8 has variable length characters. It is quite easy for the 1024 byte boundary to fall in the middle of a character. This causes us to wrongly assume we aren't dealing with utf-8.
Here is an example that shows the problem:
I also added a missing
docstring
and fixed a typo that pops up when trying to use non-openai embeddings. LMK, if I should put those in a different PR.