Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep on pydantic v2 but import from pydantic.v1 #498

Merged
merged 14 commits into from
Jun 8, 2024
Merged

Conversation

pchalasani
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 18 lines in your changes missing coverage. Please review.

Project coverage is 67.16%. Comparing base (422cb6c) to head (d16a2ca).
Report is 4 commits behind head on main.

Current head d16a2ca differs from pull request most recent head 1fbd3a1

Please upload reports for the commit 1fbd3a1 to get more accurate results.

Files Patch % Lines
langroid/vector_store/lancedb.py 9.09% 10 Missing ⚠️
langroid/pydantic_v1/main.py 0.00% 4 Missing ⚠️
langroid/pydantic_v1/__init__.py 50.00% 2 Missing ⚠️
...oid/agent/special/lance_rag/query_planner_agent.py 0.00% 1 Missing ⚠️
langroid/agent/special/neo4j/neo4j_chat_agent.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   71.29%   67.16%   -4.14%     
==========================================
  Files          95       97       +2     
  Lines        8515     8497      -18     
==========================================
- Hits         6071     5707     -364     
- Misses       2444     2790     +346     
Flag Coverage Δ
unittests 67.16% <60.86%> (-4.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pchalasani pchalasani merged commit c0ec38b into main Jun 8, 2024
1 of 3 checks passed
@pchalasani pchalasani deleted the pydantic-v2 branch June 8, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant