Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all direct links to languagetransfer.org #44

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Remove all direct links to languagetransfer.org #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 1 addition & 27 deletions js/components/About/About.react.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,14 +64,7 @@ const About = () => {
will take care of itself!
</Text>

{donationLinksNotAllowedBecauseGooglePlayIsAStinkyPooPoo ? (
<>
<Text style={[styles.bodyText, styles.bodyTextAboveButton]}>
Language Transfer is a unique project in more ways than one.
Learn more about Language Transfer here:
</Text>
</>
) : (
{donationLinksNotAllowedBecauseGooglePlayIsAStinkyPooPoo ? null : (
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

donationLinksNotAllowedBecauseGooglePlayIsAStinkyPooPoo is always true so why even keep the dead code?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that the next dude who see that line knows Google did something evil?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that it can be enabled again when it's published on F-Droid.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that it can be enabled again when it's published on F-Droid.

yeah, this was the original idea, we just haven't gotten around to it

<>
<Text style={styles.bodyText}>
Language Transfer is totally free, developed by Mihalis
Expand Down Expand Up @@ -132,25 +125,6 @@ const About = () => {
</>
)}

<View style={styles.additionalButton}>
<TouchableNativeFeedback
onPress={() => {
log({
action: 'visit_website',
surface: 'about',
});
Linking.openURL('https://www.languagetransfer.org/about');
}}
useForeground={true}>
<View style={styles.additionalButtonInner}>
<Text style={styles.additionalButtonText}>
Visit languagetransfer.org
</Text>
<Icon name="link" type="font-awesome-5" />
</View>
</TouchableNativeFeedback>
</View>

<View style={styles.additionalButton}>
<TouchableNativeFeedback
onPress={() => {
Expand Down
21 changes: 1 addition & 20 deletions js/components/LanguageHome/LanguageHome.react.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,26 +108,7 @@ const LanguageHomeBody = ({route}: {route: any}) => {
</TouchableNativeFeedback>
</View>

{donationLinksNotAllowedBecauseGooglePlayIsAStinkyPooPoo ? (
<View style={styles.additionalButton}>
<TouchableNativeFeedback
onPress={() => {
log({
action: 'visit_website',
surface: 'language_home',
});
Linking.openURL('https://www.languagetransfer.org/');
}}
useForeground={true}>
<View style={styles.additionalButtonInner}>
<Text style={styles.additionalButtonText}>
Visit languagetransfer.org
</Text>
<Icon name="link" type="font-awesome-5" />
</View>
</TouchableNativeFeedback>
</View>
) : (
{donationLinksNotAllowedBecauseGooglePlayIsAStinkyPooPoo ? null : (
<View style={styles.additionalButton}>
<TouchableNativeFeedback
onPress={() => {
Expand Down