add ugly workaround for error popup position problem (overlaps text i…

…n Firefox)
languagetool-org · Dec 22, 2013 · c170eb1 · c170eb1
1 parent 795434b
commit c170eb1
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/www/online-check/tiny_mce/plugins/atd-tinymce/editor_plugin.js b/www/online-check/tiny_mce/plugins/atd-tinymce/editor_plugin.js
@@ -693,7 +693,17 @@ AtDCore.prototype.isIE = function() {
            ed.selection.select(e.target);
            p1 = dom.getPos(e.target);
            var xPos = p1.x;
-           m.showMenu(xPos, p1.y + e.target.offsetHeight - vp.y);
+
+           // moves popup a bit down to not overlap text:
+           //TODO: why is this needed? why does the text (tinyMCE content) have a slightly lower start position in Firefox?
+           var posWorkaround = 0;
+           if(navigator.userAgent.toLowerCase().indexOf('firefox') > -1) {
+             posWorkaround = 10;
+           } else {
+             posWorkaround = 2;
+           }
+
+           m.showMenu(xPos, p1.y + e.target.offsetHeight - vp.y + posWorkaround);
            this.menuVisible =  true;
            var menuDiv = $('#menu_checktext_spellcheckermenu_co');
            if (menuDiv) {

diff --git a/www/online-check/tiny_mce/plugins/atd-tinymce/src/editor_plugin.js b/www/online-check/tiny_mce/plugins/atd-tinymce/src/editor_plugin.js
@@ -370,7 +370,17 @@
            ed.selection.select(e.target);
            p1 = dom.getPos(e.target);
            var xPos = p1.x;
-           m.showMenu(xPos, p1.y + e.target.offsetHeight - vp.y);
+
+           // moves popup a bit down to not overlap text:
+           //TODO: why is this needed? why does the text (tinyMCE content) have a slightly lower start position in Firefox?
+           var posWorkaround = 0;
+           if(navigator.userAgent.toLowerCase().indexOf('firefox') > -1) {
+             posWorkaround = 10;
+           } else {
+             posWorkaround = 2;
+           }
+
+           m.showMenu(xPos, p1.y + e.target.offsetHeight - vp.y + posWorkaround);
            this.menuVisible =  true;
            var menuDiv = $('#menu_checktext_spellcheckermenu_co');
            if (menuDiv) {