Skip to content

Commit

Permalink
[pt] Added rule ID: TESE_PHD_FICOU_DEMONSTRADO_QUE_DEMONSTRÁMOS_QUE
Browse files Browse the repository at this point in the history
  • Loading branch information
@marcoagpinto
marcoagpinto committed Mar 13, 2022
1 parent 920f9f9 commit 17dc364
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
View file
Expand Up @@ -42123,6 +42123,28 @@ O objetivo é alcançar o terreno do inimigo. → O objetivo é alcançar o terr
</rule>


<!-- FICOU DEMONSTRADO QUE demonstrámos que -->
<rule id='TESE_PHD_FICOU_DEMONSTRADO_QUE_DEMONSTRÁMOS_QUE' name="Tese Doutoramento: Expressões do tipo 'ficou demonstrado que' → ‘demonstrámos que'">
<!-- Created by Marco A.G.Pinto, Portuguese rule 2022-03-13 (1-JAN-2022+) -->
<!--
Ficou demonstrado que alterações nas baixas em combate degradaram a capacidade ofensiva. → Demonstrámos que alterações nas baixas em combate degradaram a capacidade ofensiva.
-->
<pattern>
<marker>
<and>
<token regexp='no' inflected='yes'>ficar</token>
<token postag='VMIS3S0' postag_regexp='no'/>
</and>
<token postag='VMP00S.+' postag_regexp='yes'/>
</marker>
<token>que</token>
</pattern>
<message>Se for uma tese de doutoramento, verifique se o 'tom' de redação é o apropriado.</message>
<suggestion><match no='2' postag='VMP00S.+' postag_regexp="yes" postag_replace='VMIS1P0'/></suggestion>
<example correction="Demonstrámo|Demonstrámos"><marker>Ficou demonstrado</marker> que alterações nas baixas em combate degradaram a capacidade ofensiva.</example>
</rule>


<!-- POR ISSO aí/assim/daí/isso -->
<rulegroup id='POR_ISSO_AÍ_ASSIM_DAÍ_ISSO' name="Simplificar: por isso → aí/assim/daí/isso">
<!-- Created by Marco A.G.Pinto, Portuguese rule 2022-01-24/25 (Checked/Enhanced) (1-JAN-2022+) -->
Expand Down

15 comments on commit 17dc364

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ Ricardo Joseh Lima

Here are the results in 600 000 sentences:
1.txt

Portuguese (Portugal): 7 total matches
Portuguese (Portugal): ø0.00 rule matches per sentence
Portuguese (Portugal): 17323 input lines ignored (e.g. not between 10 and 300 chars or at least 4 tokens)

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we are at it, should I also extend the rule to:
"Ficou demonstrado"
to:
"Fica demonstrado"
?

@ricardojosehlima
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
This is a great idea. However I see some problems:
1-) the smaller: the suggestion is 'demonstrámos' with diacritic on 'a' whereas in Brazil there is no such diacritic in this case.

2-) Not always the passive can be alternated with 1st person plural. Passives in many cases exist to erase the agent, whereas in 1st person plural, well, the agent is somehow there. See the cases below:

  • A emenda de bancada foi dividida em blocos, e ficou definido que Raupp (Valdir e Marinha), Ivo Cassol, Luiz Cláudio destinariam sua parte para a região da Zona ...
  • Nesta segunda-feira, em reunião na sede da Federação de Futebol do Estado do Rio de Janeiro, ficou definido que o campeão estadual sairá de um confronto entre os vencedores da Taça Guanabara e da Taça Rio.

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ricardojosehlima

I have improved the rule:
d0390ad

The morphologic dictionary has hundreds/thousands of wrong verbs forms.

I fixed manually the ones that appear in our 600 000 results:
f3fd7c8

See results here:
2.txt

Somewhere this year I will code a morphologic dictionary editor in my app Proofing Tool GUI so that wrong forms can be fixed with little work, since it takes a very long time, and it is painful to delete one by one by hand in removed.txt .

@ricardojosehlima
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, ok!
But I still think that here

A emenda de bancada foi dividida em blocos, e ficou definido que Raupp (Valdir e Marinha), Ivo Cassol, Luiz Cláudio destinariam sua parte para a região da Zona

Neither definimos, defino or defini is an option. Someone defined that Raupp... Some people defined that Raupp... I am not involved in this decision, so 1st person couldn't be an alternative, agree?

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhhhhhh... I will take a look at it in the afternoon.

🙂

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhhhhhhh... I know what is wrong 🙂 it is 10:27am, I am going to do some exercise and after lunch I will fix it.

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhhh... I don't understand now 🙂

Are you saying that with the verb "definir" it shouldn't suggest anything?

The rule won't be 100% right for all verbs, it will be best with the ones similar to "provar", "demonstrar", etc.

@marcoagpinto
Copy link
Member Author

@marcoagpinto marcoagpinto commented on 17dc364 Mar 15, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"definido" is also an adjective.

Maybe I should exclude all verbs that are also adjectives/nouns?

What is your opinion?

@ricardojosehlima
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main point is that the passive and the 1st person plural are not always interchangeable. If I am writing a text of my own and use the passive, I can change it to 1st person plural. However, if the action was not made by me, I don't see the use of the 1st person plural as adequate.
Look:

Os cientistas se reuniram para discutir os argumentos. Ficou provado que a teoria de João seria a mais adequada.

"Ficou provado" cannot be replaced by "Provamos".

The rule should have to be able to check the real actor of the verb of the passive in order to change the passive to 1st person plural, something I particularly don't see possible to be done.

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhhh… in PhD theses one should always write: "provámos" or "provei".

It is a thesis style for PhDs according to my supervisors.

In my redaction I always use plural since it is the best to do because there are thesis supervisors, and thus it would be bad to write in singular.

@ricardojosehlima
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you. However outside this scope the rule remains with the problems I listed.

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will make it “picky”

🙂

and the problem is solved.

@marcoagpinto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!
c579ec4

399601c

@ricardojosehlima
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Both you and LT!

Please sign in to comment.