Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] "a common used" #1723

Open
tiff opened this issue Jul 18, 2019 · 9 comments
Open

[en] "a common used" #1723

tiff opened this issue Jul 18, 2019 · 9 comments
Labels

Comments

@tiff
Copy link
Member

tiff commented Jul 18, 2019

It's a common used tool.

We don't detect that "common" should be "commonly"

@tiff tiff added the English label Jul 18, 2019
@tiff
Copy link
Member Author

tiff commented Jul 18, 2019

Same with:

The frequent ordered dish.
Facebook is a popular common used tool for spammers.
A spelling error can reliable be detected.

@tiff
Copy link
Member Author

tiff commented Jul 18, 2019

Also, there's a be missing in this sentence:

A spelling error can reliably detected.

But the rule that triggers is DID_BASEFORM which is rather unrelated.

@tiff
Copy link
Member Author

tiff commented Jul 18, 2019

Another one:

The initial installed software is working.

@tiff
Copy link
Member Author

tiff commented Jul 18, 2019

Did some research: In order to provide a suggestion we need to convert the adjective into an adverb. Shouldn't be too hard, there are only a few edge cases: https://www.englisch-hilfen.de/en/grammar/adverbien.htm

@danielnaber
Copy link
Member

I'm giving up and assign it to @MikeUnwalla. Here are some false alarms I had to fight with. Mike: It's okay if you get this working without any suggestion - we can later add that via Java code.

You're a natural born talker.
I would like to try the blue striped skirt. 
The boss said this group is a real mixed bag.
I would like to try the blue striped skirt.
It is unlikely that such a cool headed person got upset.
There was danger lest the secret become known.

@MikeUnwalla
Copy link
Contributor

I started this rule (cf36518). I must add more rules.

@tiff, I am not sure what to do about "The frequent ordered dish." It is not a full sentence (there is no verb).

@tiff
Copy link
Member Author

tiff commented Aug 9, 2019

Maybe this:

Barbecue Chicken Sandwich is one of the most frequent ordered dish and the most loved one

Not sure if this should be "frequently"

MFU: Yes, it should be 'frequently'.

@tiff
Copy link
Member Author

tiff commented Aug 9, 2019

Maybe this is better:

Roast pork belly aka Sio Bak aka Siu Yoke is one of the most well loved, and frequent(ly) ordered dish for Chinese cuisine.
This simple egg and tomato stir-fry was a frequent(ly) ordered dish in both restaurants

@MikeUnwalla
Copy link
Contributor

MikeUnwalla commented Aug 12, 2019

This is a list of the errors mentioned above. If you find more problems, add them to this list.

  • It's a common used tool.
  • [-] The frequent ordered dish. Out of scope because it is an incomplete sentence.
  • Facebook is a popular common used tool for spammers.
  • [-] A spelling error can reliable be detected. Premium MD_NN_VB suggests a plural noun or an adverb.
  • A spelling error can reliably detected. Open-source DID_BASEFORM finds an error in the phrase. These sentences [and corrections] show that a rule to suggest 'be' will be difficult:
    A spelling error can reliably detected these days. [be detected]
    A grammar checker can reliably detected these errors. [detect]
  • The initial installed software is working. Done ADVERB_OR_HYPHENATED_ADJECTIVE rule 3. @tiff, @danielnaber , please give your comments/suggestions about the FP. There are too many, but I want you to see the problem, which seems to be semantic, not grammatical. MFU update: After discussion with Daniel, changed the rule to find only the incorrect sentence.
  • Barbecue Chicken Sandwich is one of the most frequent ordered dish and the most loved one. Done ADVERB_OR_HYPHENATED_ADJECTIVE rule 4.
  • Roast pork belly aka Sio Bak aka Siu Yoke is one of the most well loved, and frequent ordered dish for Chinese cuisine.
  • This simple egg and tomato stir-fry was a frequent ordered dish in both restaurants.

MikeUnwalla added a commit that referenced this issue Aug 12, 2019
These improvements are a prerequisite for a rule for #1723.
MikeUnwalla added a commit that referenced this issue Aug 12, 2019
@tiff , @danielnaber , I think that there are too many FP. This rule is not useful. I cannot see how to solve the problem.
MikeUnwalla added a commit that referenced this issue Aug 19, 2019
@danielnaber , I do not understand why the 'skip' does not work. Any ideas?
TiagoSantos81 added a commit to TiagoSantos81/languagetool that referenced this issue Oct 20, 2019
TiagoSantos81 added a commit to TiagoSantos81/languagetool that referenced this issue Oct 20, 2019
@udomai udomai added the potential-AI Potentially for the AI-team label Apr 21, 2021
@MikeUnwalla MikeUnwalla removed their assignment Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants