Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[en] DID_BASEFORM false positive #1727

Open
mateon1 opened this issue Jul 18, 2019 · 1 comment
Open

[en] DID_BASEFORM false positive #1727

mateon1 opened this issue Jul 18, 2019 · 1 comment
Labels

Comments

@mateon1
Copy link

mateon1 commented Jul 18, 2019

$ java -jar languagetool-commandline.jar - <<< "...; half of them missed their mark while those that didn't missed Dragonov's vitals."
No language specified, using English (no spell checking active, specify a language variant like 'en-GB' if available)
Working on STDIN...
1.) Line 1, column 61, Rule ID: DID_BASEFORM[4]
Message: The verb 'didn't' requires base form of this verb: 'miss'
Suggestion: miss
...em missed their mark while those that didn't missed Dragonov's vitals. 
                                                ^^^^^^                    
Time: 1819ms for 1 sentences (0.5 sentences/sec)

Seems like there needs to be an exception for "those that didn't", "those who didn't", "ones that didn't", "ones who didn't", and possibly some others. Maybe the exception needs to match "while"? I'm not sure.

@MikeUnwalla MikeUnwalla self-assigned this Jul 26, 2019
MikeUnwalla added a commit that referenced this issue Jul 26, 2019
I do not know how to solve the false positive.
@MikeUnwalla
Copy link
Contributor

I cannot see how to correct this false positive.

@MikeUnwalla MikeUnwalla removed their assignment Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants