Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another problem with ruleEditor #497

Closed
kostyfisik opened this issue Aug 20, 2016 · 3 comments
Closed

Another problem with ruleEditor #497

kostyfisik opened this issue Aug 20, 2016 · 3 comments
Labels

Comments

@kostyfisik
Copy link
Contributor

kostyfisik commented Aug 20, 2016

I can put

<rule id="testlj">
    <pattern>
        <marker>
        <token postag="ADJ:.*"  postag_regexp="yes"/>
        <token postag="NN:.*" postag_regexp="yes"/>
        </marker>
        <or>
            <token postag="NN:.*" postag_regexp="yes"/>
            <token postag="SENT_END" />
        </or>

    </pattern>
    <message>test:
    </message>
     <!-- <example>Смелого пуля.</example> -->
    <example correction=""> <marker>хрестоматийное слово</marker>.</example>
</rule>

into ruleEditor and

screenshot from 2016-08-20 13-26-53

while there is only one <rule> block here...

@kostyfisik kostyfisik added the bug label Aug 20, 2016
@jaumeortola
Copy link
Member

When <or> is used, several rules are generated internally. It is not easy to do it otherwise. To fix the problem in the rule editor would require some time and work. I am not sure if it is worthwhile, because <or> is not used very often.

@kostyfisik
Copy link
Contributor Author

Probably it should provide a hint which part of <or> it is using and show output for both rules on a web page... I am struggling with a problem on antipattern, however, it appears only with block. See http://forum.languagetool.org/t/antipattern-is-not-working/991/32 for details.

danielnaber added a commit to languagetool-org/languagetool-community-website that referenced this issue Aug 25, 2016
@danielnaber
Copy link
Member

I've improved the error message to mention the issue with <or>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants