[LO extension / Standalone] add the possibility to define more than o… #10542
Conversation
…ne user defined option to a rule by option panel
| String str = values[i].trim(); | ||
| char c = values[i].charAt(0); | ||
| str = str.substring(1); | ||
| if (c == 's') { |
There was a problem hiding this comment.
A comment with examples would be nice here
|
|
||
|
|
||
|
|
||
|
|
| char c; | ||
| for (int i = 0; i < obs.length; i++) { | ||
| Object o = obs[i]; | ||
| if (o instanceof Integer) { |
There was a problem hiding this comment.
Is this code duplicated from above? Can we avoid the duplication?
| Object maxConfigurableValue; | ||
| if (defaultType.equals("Integer")) { | ||
| defaultValue = (int) rOptions.get(i).get("defaultValue"); | ||
| minConfigurableValue = (int) rOptions.get(i).get("minConfigurableValue"); |
There was a problem hiding this comment.
minConfigurableValue etc. should probably be a constant, as it is used several times
| @SuppressWarnings("unchecked") | ||
| List<Map<String,Object>> rOptions = (List<Map<String, Object>>) o; | ||
| ruleOptions = new RuleOption[rOptions.size()]; | ||
| for (int i = 0; i < rOptions.size(); i++) { |
| Object[] objects = new Object[values.length]; | ||
| for (int i = 0; i < values.length; i++) { | ||
| char c = values[i].charAt(0); | ||
| String str = values[i].substring(1); | ||
| if (c == 's') { | ||
| objects[i] = str; | ||
| } else if (c == 'b') { | ||
| objects[i] = Boolean.parseBoolean(str); | ||
| } else if (c == 'f') { | ||
| objects[i] = Float.parseFloat(str); | ||
| } else if (c == 'd') { | ||
| objects[i] = Double.parseDouble(str); | ||
| } else if (c == 'c') { | ||
| objects[i] = str.charAt(0); | ||
| } else if (c == 'i') { | ||
| objects[i] = Integer.parseInt(str); | ||
| } else { // compatible to old version | ||
| objects[i] = Integer.parseInt(values[i]); |
|
@fabrichter Maybe you can quickly check whether the change in |
|
The requested changes was done |
|
@danielnaber I would also add a better getter for the configuration values like this: public <T> T getConfigValueByID(String ruleID, int index, Class<T> clazz, T defaultValue) {
Object[] value = configurableRuleValues.get(ruleID);
if (value == null) return defaultValue;
if (index >= value.length) return defaultValue;
if (!clazz.isInstance(value[index])) return defaultValue;
return (T) value[index];
}This should be used instead of the existing manual accesses and checks to inner values of |
|
The requested changes from @fabrichter and @danielnaber were done. |
The change creates the ability to define more than one custom option per rule.
All existing rules with custom options have been adjusted. The options panel has been expanded accordingly.
The API and the HTTP server (ConfigurationInfo) have been adapted. Upward and downward compatibility between versions lower than 6.5 and higher than 6.4 was ensured.
A second option was added for the GermanFillerWordsRule as a test case.
All changes were tested.
To-do: Some more rules should be expanded to include additional options.
A merge can be performed.