Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added rule ID:ATUAIS_TER_AGORA_HOJE_PRESENTEMENTE #10569

Closed
wants to merge 3 commits into from

Conversation

marcoagpinto
Copy link
Member

Heya, @susanaboatto and @p-goulart ,

Here is a brand-new rule.

I am terrible at picking names for rules, could you suggest a better name?

It only has one hit in 900 000 sentences, which is the one I included in the singular form example:

Os computadores aprenderam a jogar xadrez há muitos anos, mas nem sempre tiveram a força que têm hoje.
                                                                                         ^^^^^^^^^^^^ 

@susanaboatto
Copy link
Collaborator

susanaboatto commented May 6, 2024

Perhaps a more concise name for this rule would be AGORA_ATUAL 🌸

Also, need to look into why this test failed.

@marcoagpinto
Copy link
Member Author

Done!

Why did the tests fail?

On the day I committed both pull requests, they were all green.

@p-goulart
Copy link
Collaborator

junit.framework.AssertionFailedError: Portuguese (Portugal) rule ATUAIS_TER_AGORA_HOJE_PRESENTEMENTE[1] uses quotes around <suggestion>...<suggestion> in its <message>, this should be avoided: 'Num contexto formal empregue "<suggestion>\3</suggestion>".'

@marcoagpinto
Copy link
Member Author

@p-goulart

Done!

But it says it has conflicts.

@marcoagpinto
Copy link
Member Author

@susanaboatto @p-goulart

Maybe I should create a pull request with both of these pull requests to fix the conflicting files?

@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20240505_0721 branch May 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants