ML-based suggestions ordering (AGPL dependency removed) #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odels evaluator](https://github.com/komiya-atsushi/xgboost-predictor-java), added models.
…tool into spelling-corrections-ordering # Conflicts: # languagetool-core/pom.xml # languagetool-core/src/main/java/org/languagetool/rules/spelling/morfologik/suggestions_ordering/SuggestionsOrderer.java # languagetool-core/src/main/java/org/languagetool/rules/spelling/morfologik/suggestions_ordering/SuggestionsOrdererConfig.java # languagetool-core/src/test/java/org/languagetool/rules/spelling/morfologik/suggestions_ordering/SuggestionsOrdererTest.java # languagetool-server/src/main/java/org/languagetool/server/HTTPServerConfig.java
…etool into spelling-corrections-ordering
|
Now using the https://github.com/komiya-atsushi/xgboost-predictor-java lib, it is licensed under the Apache 2.0. Is it Ok? |
|
Thanks, the Apache 2.0 license is fine. |
|
I will merge this pull request today. |
danielnaber
reviewed
Jul 27, 2018
| @@ -189,6 +196,23 @@ | |||
| <scope>test</scope> | |||
| </dependency> | |||
|
|
|||
| <!--xgboost-related pmml dependencies--> | |||
| <!--<dependency>--> | |||
There was a problem hiding this comment.
Can be removed, or is there a reason to only comment them out?
| @@ -0,0 +1,18 @@ | |||
| package org.languagetool.languagemodel; | |||
There was a problem hiding this comment.
Please add a license header here (and all the other new files)
|
|
||
| private boolean MLAvailable = true; | ||
|
|
||
| private static SuggestionsOrderer.NGramUtil nGramUtil = null; |
There was a problem hiding this comment.
Do these have to be static?
| int startPos = sentence.indexOf(word); | ||
| int wordLength = word.length(); | ||
| List<String> suggestionsOrdered = suggestionsOrderer.orderSuggestionsUsingModel(suggestions, word, languageTool.getAnalyzedSentence(sentence), startPos, wordLength); | ||
| assertTrue(suggestionsOrdered.containsAll(suggestions)); |
There was a problem hiding this comment.
Shouldn't this assert check the order instead of just whether the items exist, or am I missing something?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #1020
AGPL dependency removed