Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add indonesian rules from #593 #595

Closed
wants to merge 4 commits into from
Closed

Add indonesian rules from #593 #595

wants to merge 4 commits into from

Conversation

turfaa
Copy link

@turfaa turfaa commented Nov 7, 2016

I am adding Indonesian rules from #593
Need further reviews and improvements, because I added it using automatic script, and the source is from https://id.wikipedia.org/wiki/Wikipedia:Daftar_kosakata_bahasa_Indonesia_yang_sering_salah_dieja

I also don't include sentence example (because of this automatic script thing)

Copy link

@chocochino chocochino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong lines and how to fix it

line fault
41 cuman is not official Indonesian word
56 Saos is not official Indonesian word, consider changing to Saus
57 Saos is not official Indonesian word, consider changing to Saus
2057 Already exist rule himbau to imbau, consider deleting
757 Already exist rule ma'af to maaf with single quote, consider deleting
2087 ideology is not official Indonesian word, consider changing to ideologi
2093 ideology is not official Indonesian word, consider changing to ideologi
2107 Already exist rule institute to institut, consider deleting
2157 Already exist rule imaginasi to imajinasi, consider deleting
2227 Fuzzy rule: consider add rule missal to misal
2227 Fuzzy rule: consider add rule massal to masal
5547 Consider change to ustazah
5553 Consider change to ustazah

Copy link

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, you inherited from #593 a language code of in, which was deprecated a long time ago. The valid code for bahasa Indonesia is id.

I am creating a new PR with all the changes combined and corrected.

@turfaa
Copy link
Author

turfaa commented Nov 24, 2016

@chocochino @jayvdb thanks! I've solved those issues.

@danielnaber
Copy link
Member

I'm closing this so we don't have lingering pull requests, feel free to re-open or open a new request if there's serious support for adding Indonesian.

berviantoleo pushed a commit to bervProject/Kata-Baku-Checker-for-PO-File that referenced this pull request Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants