[pt] Add DOUBLE_INFINITIVE rulegroup #8682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- addresses languagetooler-gmbh/languagetool-premium#5538; - really simple initial version taking care only of clearly ungrammatical epistemic modal double infinitives; - e.g. 'ele dever ter ido embora', 'poder ter chovido mais cedo'; - methinks it's safe to assume these are typos.
added 2 commits
May 23, 2023 17:33
- too many non-epistemic uses of modal 'poder', which complicates things a bit... - I kept the antipatterns made for 'poder', since they're technically also possible for 'dever', but 'poder' itself must be handled elsewhere...
|
@susanaboatto ⬆️ tests pass – this is a very narrowly defined rule just to address the original issue; handling all incorrect double infinitives is a much bigger task, it seems. |
|
(also I still can't add reviewers, labels, etc. 😭) |
Please try again now. |
Works a charm, thanks! |
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
Show resolved
Hide resolved
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
Show resolved
Hide resolved
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
Show resolved
Hide resolved
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes languagetooler-gmbh/languagetool-premium#5538;
really simple initial version taking care only of clearly ungrammatical epistemic modal double infinitives;
e.g. 'ele dever ter ido embora',
'poder ter chovido mais cedo'methinks it's safe to assume these are typos.