-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Add words to spellcheck #8705
Conversation
- all of these occurred 15+ times in w20; - there are many questions.
|
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
Outdated
Show resolved
Hide resolved
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
Outdated
Show resolved
Hide resolved
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
Outdated
Show resolved
Hide resolved
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/added.txt
Outdated
Show resolved
Hide resolved
...ol-language-modules/pt/src/main/resources/org/languagetool/resource/pt/hunspell/spelling.txt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
also re: |
PINs PIN NCMP000 | ||
switch switch NCMS000 | ||
Switch switch NCMS000 | ||
SWITCH switch NCMS000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This triple version of words (lower case, first upper case, all upper case) shouldn't be necessary. It will probably create problems in the synthesis of suggestions.
Is anything not working as expected if these three versions are missing? The speller? Then add the three words to spelling.txt, but not to added.txt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, they're added to the hunspell files but IMO they shouldn't even be required there, which is already something I brought up with @susanaboatto when she was describing to me what was to be done here. I'll describe it in an issue. If this variation causes issues in added.txt
, then removed they shall be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this @jaumeortola!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would eliminate the need to add capitalized and all upper case words to speller.txt. https://github.com/languagetooler-gmbh/languagetool-premium/issues/4703
All of these occurred 15+ times in w20.
Profa
andDrª
, as I think we need to work out a better solution here using the abbreviation rules we already have (languagetooler-gmbh/languagetool-premium#5732)hahaha
, and I'm certain we can add some kind of smart-ish 'laughing' rule that ignores stuff like(h[ea])+h?
– just a thought... it's annoying having to manually ignore laughter... could be a style thing (languagetooler-gmbh/languagetool-premium#5732);adequa
available in all non-ultra-formal registers? (languagetooler-gmbh/languagetool-premium#5734)okay
is weird, but I'm not sure where we stand on that type of thing; do we ask to correct toOK
? I personally write 'okay' in pt-BR but I might just be abroad too long (not a huge issue, let's assume it's a foreign word for now);LGBT
? they're used almost exclusively adjectivally, but they're not quite adjectives... they're not exactly adjectival phrases, either.