Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[de] improve germanSpeller #9821

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[de] improve germanSpeller #9821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8702499
[de] improve germanSpeller
AgnesKleinhans Dec 4, 2023
686fcb1
[de] add test + improve GermanSpeller.java
AgnesKleinhans Dec 6, 2023
c6a3cdd
[de] add words to spelling/infix-s/no-infix-s
AgnesKleinhans Dec 6, 2023
7c00b44
[de] remove/add words
AgnesKleinhans Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...getool-language-modules/de/src/main/java/org/languagetool/rules/de/GermanSpellerRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2215,6 +2215,18 @@ protected boolean ignorePotentiallyMisspelledWord(String word) throws IOExceptio
List<String> parts = compoundTokenizer.tokenize(wordNoDot);
boolean nonStrictMode = false;
if (parts.size() == 1) {
String part2 = " ";
for (String w : wordsWithoutInfixS) { // wordsWithHyphen
if (word.startsWith(w)) {
part2 = word.substring(w.length());
if (part2.startsWith("-")) {
part2 = part2.substring(1);
} else if (word.length() > w.length() && w.length() > 3) {
part2 = uppercaseFirstChar(part2.substring(0));
}
return (!isMisspelled(part2) || ignorePotentiallyMisspelledWord(part2)) && isNoun(part2);
}
Comment on lines +2218 to +2228
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stretch looks over-indented 🙃

}
parts = nonStrictCompoundTokenizer.tokenize(wordNoDot);
nonStrictMode = true;
}
Expand Down
5 changes: 4 additions & 1 deletion ...language-modules/de/src/main/resources/org/languagetool/resource/de/hunspell/spelling.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61678,4 +61678,7 @@ Petruskreuze/SN
Pileolus
Pileoli
Pentalpha/S
Römerkragen/S
Römerkragen/S
Alexander-von-Humboldt-Realschule
Augsburg-Haunstetten-Siebenbrunn
Denavit-Hartenberg-Parameter/S
3 changes: 2 additions & 1 deletion ...ool-language-modules/de/src/main/resources/org/languagetool/resource/de/words_infix_s.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,4 +311,5 @@ Werbeanbringung
Wohlgeformtheit
Anomalität
Dämmerung
Studiengang
Studiengang
Ayurveda
77 changes: 74 additions & 3 deletions ...-language-modules/de/src/main/resources/org/languagetool/resource/de/words_no_infix_s.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ Teich
Trail
Villa
Vinyl
Wacht
Yacht
Kirmes
Gewächs
Expand Down Expand Up @@ -1756,8 +1755,80 @@ Multizellen
Aminosäuren
Ausreißer
Drehzahl
Absenk
Gastro
Ausdauer
Anthropomorphismus
Charles-Bonnet-Syndrom
Charles-Bonnet-Syndrom
Allergie
Trüffel
Fondue
Buddha
Zellulose
Angehörigen
Anthropomorphismus
Waffel
Black-Friday-
Anti-
All-in-One-
Remote-Work-
American-Football-
All-you-can-eat-
Double-Opt-In-
Cash-Conversion-
Al-Shifa-
Anti-Stokes–
Farm-to-Fork
Afro-Pop-
Afro-
Backup-Restore-
Before-Class-
Make-up-
Always-on-
Fake-
Build-to-Order-
Air-Asia-
Airport-
Workshop-
Continuous-Improvement-
Above-the-Fold-
CDU-
SPD-
AfD-
E-Commerce-Conversion-
E-Commerce-
Black-Week-
Boho-
Charles-Bonnet-
Allergiker
Vehicle-to-Grid-
Best-Practice-
Agri-Photovoltaik-
Face-to-Face-
CBD-
Hausstaubmilben
Cradle-to-Cradle-
Heavy-Metal-
Akkusativ
Dativ
Genitiv
Nominativ
Due-Diligence-
Deep-Learning-
Transformer-
Elektrolyse
Gebrauchshund
EU-Mercosur-
Go-To-Market
Feedback
Pop-Up-
Pop-
.com-
Business-to-Business-
B2B-
Geflüchteten
Coming-Home-
Gourmet
Betroffenen
E-Commerce
Adjektiv
Karaoke
3 changes: 3 additions & 0 deletions ...ol-language-modules/de/src/test/java/org/languagetool/rules/de/GermanSpellerRuleTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ public class GermanSpellerRuleTest {
@Test
public void testIgnoreMisspelledWord() throws IOException {
GermanSpellerRule rule = new GermanSpellerRule(TestTools.getMessages("de"), GERMAN_DE);
assertTrue(rule.ignorePotentiallyMisspelledWord("Farm-to-Fork-Bereich"));
assertFalse(rule.ignorePotentiallyMisspelledWord("Englisch-KenntnisseWeitere"));
assertTrue(rule.ignorePotentiallyMisspelledWord("Black-Friday-Schnäppchen"));
AgnesKleinhans marked this conversation as resolved.
Show resolved Hide resolved
assertTrue(rule.ignorePotentiallyMisspelledWord("Atmosphärenkonzept"));
assertTrue(rule.ignorePotentiallyMisspelledWord("Wölkchenbildung"));
assertFalse(rule.ignorePotentiallyMisspelledWord("Abschlussgruße")); // probably "...grüße"
Expand Down