Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suspend_while_paused option to Kodi check #60

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

nioncode
Copy link
Contributor

@nioncode nioncode commented Aug 4, 2019

Fixes #59.

I also added some tests, but didn't run them, because I'm not familiar with setting this up and just hope travis will report any issues.

@nioncode nioncode force-pushed the suspend_while_paused branch 2 times, most recently from cca9781 to f1e31c7 Compare August 4, 2019 20:22
@codecov
Copy link

codecov bot commented Aug 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9f707fe). Click here to learn what that means.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #60   +/-   ##
=========================================
  Coverage          ?   91.73%           
=========================================
  Files             ?        8           
  Lines             ?      919           
  Branches          ?      126           
=========================================
  Hits              ?      843           
  Misses            ?       71           
  Partials          ?        5
Impacted Files Coverage Δ
src/autosuspend/checks/activity.py 87.53% <95.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f707fe...fcff3db. Read the comment docs.

@nioncode nioncode changed the title add supend_while_paused option to Kodi check add suspend_while_paused option to Kodi check Aug 4, 2019
@nioncode nioncode force-pushed the suspend_while_paused branch 3 times, most recently from cb18aa4 to c4b4d99 Compare August 4, 2019 20:42
Copy link
Owner

@languitar languitar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this very clean and tested PR! Just a few minor issues to address before I can merge this.

src/autosuspend/checks/activity.py Outdated Show resolved Hide resolved
src/autosuspend/checks/activity.py Outdated Show resolved Hide resolved
@languitar languitar added this to the 2.1 milestone Aug 6, 2019
@nioncode
Copy link
Contributor Author

nioncode commented Aug 6, 2019

Fixed and re-pushed.

@languitar languitar merged commit b3e6538 into languitar:master Aug 7, 2019
@nioncode nioncode deleted the suspend_while_paused branch August 24, 2019 21:30
@languitar languitar modified the milestones: 2.1, 3.0 Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system not suspending while Kodi is paused
2 participants