-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ising Model Tools #10
Conversation
Codecov Report
@@ Coverage Diff @@
## main #10 +/- ##
==========================================
- Coverage 89.97% 87.13% -2.85%
==========================================
Files 4 5 +1
Lines 409 443 +34
==========================================
+ Hits 368 386 +18
- Misses 41 57 +16
Continue to review full report at Codecov.
|
@ccoffrin Looks good so far. Let me write up a few tests before we merge it in. One thing I notice is that problem with the test for the noisy x and z bqpjson simulations came up in one of the simulations. It just seems the probability didn't end up high enough (0.657 < 0.7). Do you think we should try to modify the test? |
@ccoffrin it looks like everything is bug free. It is a little confusing to me that the limit argument doesn't actually give the number of printed states in the case of degeneracies, but more of a lower limit; however it seems to be behaving as intended. This should be good to merge as long as that is the intended behavior |
@zmorrell you make a good point on the behavior of the What do you think of changing the semantics to be the number energy levels that are printed with a default value of say 5? |
@ccoffrin that seems like a good approach. I would propose a default of 3, since that would be one ground state and 2 levels of excited states. I don't know that people would want much more than that, unless they needed the whole state space, which they can choose with |
Working towards #8. Thoughts @zmorrell?