Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse annealing tests, closes #2 #18

Merged
merged 3 commits into from
Feb 16, 2022
Merged

Add reverse annealing tests, closes #2 #18

merged 3 commits into from
Feb 16, 2022

Conversation

zmorrell
Copy link
Collaborator

@ccoffrin These are the best tests that I could come up with for the reverse annealing. I'm not exactly sure what sort of behavior we would expect with this protocol, so do these tests and tolerances seem reasonable to you?

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #18 (1de8723) into main (783dbf4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files           5        5           
  Lines         444      444           
=======================================
  Hits          430      430           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783dbf4...1de8723. Read the comment docs.

@ccoffrin
Copy link
Member

My proposed updates. I broke the test into two that I think are targeting the key functionalities you were getting at.

I also tweaked the reverse annealing test parameters so that the dynamics would trigger an oscillation where the swing is captured in the final state to give a very clear signature of the impacts of the reverse schedule.

Also when writing tests I suggest that we most often hardcode the number of steps that were used to save time and make the tests more controlled experiments.

@zmorrell
Copy link
Collaborator Author

@ccoffrin This all looks good to me, I'll go ahead and merge

@zmorrell zmorrell merged commit 95c0ea0 into main Feb 16, 2022
@zmorrell zmorrell deleted the rev-anneal-tests branch February 16, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants