Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to Transverse Field Ising Hamiltonian builder #21

Merged
merged 1 commit into from
Feb 16, 2022

Conversation

ccoffrin
Copy link
Member

@zmorrell, this is what I had in mind. I think most users of this feature will not need to the constant terms, so we can leave these out. Also gave the function a more descriptive name with the idea of supporting different Hamiltonians down the road. I also added some new tests targeting the constant_field capability more specifically, so that we won't regress on the bug you found.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #21 (b9a682f) into ham-builder (9ae8156) will increase coverage by 2.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ham-builder      #21      +/-   ##
===============================================
+ Coverage        94.59%   96.84%   +2.25%     
===============================================
  Files                5        5              
  Lines              444      444              
===============================================
+ Hits               420      430      +10     
+ Misses              24       14      -10     
Impacted Files Coverage Δ
src/simulate.jl 94.59% <100.00%> (+6.28%) ⬆️
src/simulate_de.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae8156...b9a682f. Read the comment docs.

@zmorrell
Copy link
Collaborator

This looks good to me. I'll go ahead and merge it into the other pull request branch

@zmorrell zmorrell merged commit 3c7f1ee into ham-builder Feb 16, 2022
@zmorrell zmorrell deleted the ham-builder-cjc branch February 16, 2022 21:09
zmorrell added a commit that referenced this pull request Feb 16, 2022
* Add hamiltonian builder, fix sum_z without weights, closes #16

* revisions to transverse_ising_hamiltonian builder (#21)

Co-authored-by: Carleton Coffrin <carleton@coffrin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants