Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any-Order Magnus Expansion #28

Merged
merged 28 commits into from
Mar 14, 2022
Merged

Any-Order Magnus Expansion #28

merged 28 commits into from
Mar 14, 2022

Conversation

ccoffrin
Copy link
Member

@ccoffrin ccoffrin commented Mar 5, 2022

WIP

@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #28 (5d213c1) into main (4a8495a) will decrease coverage by 0.04%.
The diff coverage is 95.19%.

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   92.64%   92.59%   -0.05%     
==========================================
  Files           5        5              
  Lines         476      554      +78     
==========================================
+ Hits          441      513      +72     
- Misses         35       41       +6     
Impacted Files Coverage Δ
src/simulate.jl 90.47% <94.53%> (+2.63%) ⬆️
src/base.jl 98.03% <100.00%> (-0.15%) ⬇️
src/dwave.jl 96.98% <100.00%> (-0.25%) ⬇️
src/simulate_de.jl 77.08% <100.00%> (-0.47%) ⬇️
src/ising.jl 100.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ccoffrin ccoffrin marked this pull request as ready for review March 9, 2022 15:28
@ccoffrin ccoffrin requested a review from zmorrell March 11, 2022 21:23
@ccoffrin
Copy link
Member Author

@zmorrell, I am done cleaning this up and it is ready for you to have a look before we merge it. There are a lot of revisions in the algorithm section, the changelog has a summary of them.

Copy link
Collaborator

@zmorrell zmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty much everything looks good to me. There is only one potential bug I found, and everything else is to make the code cleaner

src/dwave.jl Outdated Show resolved Hide resolved
src/simulate.jl Outdated Show resolved Hide resolved
src/simulate.jl Outdated Show resolved Hide resolved
src/simulate.jl Outdated Show resolved Hide resolved
src/simulate.jl Outdated Show resolved Hide resolved
@ccoffrin
Copy link
Member Author

great suggestions. Thanks!

@ccoffrin ccoffrin merged commit ee181f0 into main Mar 14, 2022
@ccoffrin ccoffrin deleted the general-magnus branch March 14, 2022 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants